search

openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

Update to latest zipkin-reporter2 #68

Closed mbischo closed 6 years ago

mbischo commented 6 years ago

Addresses https://github.com/openzipkin/zipkin-aws/issues/67

codefromthecrypt commented 6 years ago

LGTM

codefromthecrypt commented 6 years ago

We should do a quick scan that any shading that is no longer needed is removed (possibly there is none)

llinder commented 6 years ago

I took a quick pass through the code base and it looks like this covers the only cases where zipkin2.reporter.internal.BaseCall as used. There is a shaded copy to avoid a dependency here https://github.com/openzipkin/zipkin-aws/blob/master/storage-xray-udp/src/main/java/zipkin2/storage/xray_udp/BaseCall.java. @mbischo could you take a look at removing that and using zipkin2.Call.Base instead? It doesn't seem strictly necessary to do that for this PR but it would be a good time to clean it up if doesn't incur adding a dependency anymore.

mbischo commented 6 years ago

Closing this PR and opening a new one. Straddling the new year is throwing off the license-check plugin.