search

openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

Support gRPC in XRay Encoder #73

Open devinsba opened 6 years ago

devinsba commented 6 years ago

For those of us that use gRPC it would be nice to have the encoder support handling spans from the brave-grpc instrumentation.

I wonder if there is some abstraction we can add so we don't have to keep manually implementing these things as new RPC mechanisms are instrumented in brave, obviously HTTP is fairly well understood and the tags are standarized

codefromthecrypt commented 6 years ago

You mean a generic handler for rpc or grpc specifically?

On Thu, 29 Mar 2018 05:02 Brian Devins, notifications@github.com wrote:

For those of us that use gRPC it would be nice to have the encoder support handling spans from the brave-grpc instrumentation.

I wonder if there is some abstraction we can add so we don't have to keep manually implementing these things as new RPC mechanisms are instrumented in brave, obviously HTTP is fairly well understood and the tags are standarized

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin-aws/issues/73, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD6129XQIuB679BJ2s8PDARUsDrIToBks5ti_pbgaJpZM4S_XAC .