search

openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

brave-instrumentation-aws-java-sdk-core wasn't released as part of 0.10.1 #86

Closed wjam closed 5 years ago

wjam commented 6 years ago

Looks like the module is missing from the root POM and the version number in brave-instrumentation-aws-java-sdk-core is incorrect.

codefromthecrypt commented 6 years ago

this was intentionally not released as it is being refactored cc @devinsba

danieleorler commented 6 years ago

Will it be released sometime in the future?

devinsba commented 6 years ago

We plan to yes, I've been swamped at work and have not had the chance to wrap up the PR: https://github.com/openzipkin/zipkin-aws/pull/85

I can push it to a branch in this repo if you would like to take a shot at finishing the tests that are broken? Let me know

devinsba commented 6 years ago

To expedite: I pushed up https://github.com/openzipkin/zipkin-aws/tree/sdk-handler-refactor, please consider a PR against that branch if you have some time

devinsba commented 5 years ago

This was included in version 0.14.0