Fix (?) releasing via CircleCI

abesto commented 6 years ago

Problem: as noted in https://github.com/openzipkin/zipkin-aws/pull/95#issuecomment-408819158, the release process (initiated by pushing a tag release-MAJOR.MINOR.PATCH) wasn't triggered. CircleCI at https://circleci.com/gh/openzipkin/workflows/zipkin-aws/tree/release-0.12.1 says “zipkin-aws/release-0.12.1 has no workflows configured”.

Analysis: the documentation states that unless explicitly configured, workflow jobs are not triggered for any tags. trigger_publish is configured to be triggered on release- tags. However, it requires build, and build is not configured with a tags filter, so it was not run. Note also that conceptually, I think build is not an actual dependency of trigger_publish (but it is an actual dependency of publish_stable).

Solution: remove the dependency of trigger_publish on build, and allow build to run on tags MAJOR.MINOR.PATCH, which is the same filter configured for publish_stable. The build flow should now go:

commit on master: build -> publish_snapshot
tag release-0.0.0 -> flow(trigger_publish creates tag 0.0.0) -> flow(build -> publish_stable)
- I expect publish_snapshot to not run because it has no tags filter, and the default is to not trigger on tags.

PoC: pushed a tag release-0.0.0 to abesto/zipkin-aws with these changes, and it triggered a workflow (which terminated early at the “don't run on forks” check we have in .circleci/config.yml for the trigger_publish step): https://circleci.com/gh/abesto/zipkin-aws/2

abesto commented 6 years ago

Note that since we follow the same pattern in all CircleCI 2.0 configs, we'll need to propagate this change to all of them. To prevent duplicate work, I'd recommend cutting a release to do a “live-fire exercise” after merge.

codefromthecrypt commented 6 years ago

trying now. good analysis

codefromthecrypt commented 6 years ago

moved past, but the build is flakey.. hopefully won't die a lot :) https://github.com/openzipkin/zipkin-aws/issues/100

We should at some point get all the builds running or passing on JDK 10 or 11 anyway

codefromthecrypt commented 6 years ago

green!

openzipkin / zipkin-aws

Fix (?) releasing via CircleCI #99