search

openzipkin / zipkin-browser-extension

Chrome and Firefox browser extensions for Zipkin
Apache License 2.0
25 stars 13 forks source link

Use jest for tests #14

Closed SimenB closed 7 years ago

SimenB commented 7 years ago

Also add package-lock.json and CI on node 8 (to get npm5)

Would anyone be opposed to me dropping gulp entirely and just use webpack directly from npm scripts?

codefromthecrypt commented 7 years ago

This repo is your oyster. If no one complains. Feel free to take gulp out

codefromthecrypt commented 7 years ago

Thank you!

SimenB commented 7 years ago

Cool. The firefox add-on needs a rewrite as it'll stop working in firefox 57 (55 is current). The good thing is it uses the same API as chrome, opera and microsoft edge now, so should actually be less code and very straight forward 🙂 That also means that a fancy build system is unnecessary.

codefromthecrypt commented 7 years ago

you are such a champ for helping, Simen. Hope to see you in oslo if we can meet. I'll be there soon for javazone!

SimenB commented 7 years ago

I'll be at javazone myself, so that works out!

eirslett commented 7 years ago

Go for it! Finally some cleanup on this project! I just wish firefox supported the same api back when this was written :-( Gulp was only there to manage the abstraction etc., so removing it is good.