search

openzipkin / zipkin-dependencies

Spark job that aggregates zipkin spans for use in the UI
Apache License 2.0
176 stars 81 forks source link

Fix openzipkin/zipkin-dependencies/issues/192 #194

Closed dankolt closed 3 years ago

jorgheymans commented 3 years ago

Can you explain a bit what it is you're trying to fix here ?

dankolt commented 3 years ago

Can you explain a bit what it is you're trying to fix here ?

Bug describes in https://github.com/openzipkin/zipkin-dependencies/issues/192. When we start dependencies container crond interrupts with message: crond[1]: root: Permission denied It happens because crond starts by zipkin-dependencies user but scripts copied in Dockerfile with root owner. So I changed this behaviour and dependencies job start working now.

jorgheymans commented 3 years ago

Thanks for the clarification! @shakuzen are you ok with this fix ?

shakuzen commented 3 years ago

Error: Failed to execute goal com.mycila:license-maven-plugin:4.0.rc2:check (default) on project zipkin-dependencies-parent: Some files do not have the expected license header

I am guessing the license header end year of the Dockerfile needs to be extended to 2021.

Otherwise, LGTM.

dankolt commented 3 years ago

Error: Failed to execute goal com.mycila:license-maven-plugin:4.0.rc2:check (default) on project zipkin-dependencies-parent: Some files do not have the expected license header

I am guessing the license header end year of the Dockerfile needs to be extended to 2021.

Otherwise, LGTM.

Exactly! Thanks!

ipavlushin commented 3 years ago

Hi @jorgheymans @shakuzen ! Could you also build and push Docker image with these changes?