search

openzipkin / zipkin-gcp

Reporters and collectors for use in Google Cloud Platform
https://cloud.google.com/trace/docs/zipkin
Apache License 2.0
91 stars 54 forks source link

Adds patch until Armeria 0.91 #135

Closed codefromthecrypt closed 5 years ago

codefromthecrypt commented 5 years ago

temporary until https://github.com/line/armeria/pull/1998 We need to get things layered on this to work, most notably health checks #131, and it isn't a huge deal to C&P one ASL file I think.

@trustin @anuraaga I changed our license config to ensure vendoring doesn't impact the file pasted temporarily. When ready, we simply revert this commit.

codefromthecrypt commented 5 years ago

I need to verify classpath precedence works

codefromthecrypt commented 5 years ago

actually I think repackaging is smarter.

codefromthecrypt commented 5 years ago

verified logging still works and drop metrics increase.

2019-08-17 10:22:38.951  INFO 83341 --- [-worker-nio-2-3] c.l.a.c.l.LoggingClient                  : Response: {startTime=2019-08-17T02:22:38.946Z(1566008558946411), length=0B, duration=4525µs(4525957ns), headers=[:status=200, content-type=application/grpc, date=Sat, 17 Aug 2019 02:22:17 GMT, alt-svc=quic=":443"; ma=2592000; v="46,43,39"], trailers=[EOS, grpc-status=5, grpc-message=Requested entity was not found., google.rpc.resourceinfo-bin=EhNwcm9qZWN0cy96aXBraW4tZGV2, grpc-status-details-bin=CAUSH1JlcXVlc3RlZCBlbnRpdHkgd2FzIG5vdCBmb3VuZC4aRAordHlwZS5nb29nbGVhcGlzLmNvbS9nb29nbGUucnBjLlJlc291cmNlSW5mbxIVEhNwcm9qZWN0cy96aXBraW4tZGV2]}
$ curl -s localhost:9411/metrics|jq .
{
  "counter.zipkin_collector.messages.http": 2,
  "counter.zipkin_collector.spans_dropped.http": 3,
  "gauge.zipkin_collector.message_bytes.http": 410,
  "counter.zipkin_collector.bytes.http": 1044,
  "gauge.zipkin_collector.message_spans.http": 2,
  "counter.zipkin_collector.spans.http": 3,
  "counter.zipkin_collector.messages_dropped.http": 0
}