Open z-oo opened 5 years ago
And it is caused by isEmpty() check that is not null-safe: https://github.com/openzipkin/zipkin-gcp/blob/master/translation-stackdriver/src/main/java/zipkin2/translation/stackdriver/AttributesExtractor.java#L83
if (zipkinSpan.localEndpoint() != null && !zipkinSpan.localEndpoint().serviceName().isEmpty()) {
makes sense. I guess census is allowing you to create an exporter without a service name. This is a bug over there, but still, we should guard here also.
Example:
result in
while
works fine.