search

openzipkin / zipkin-gcp

Reporters and collectors for use in Google Cloud Platform
https://cloud.google.com/trace/docs/zipkin
Apache License 2.0
91 stars 54 forks source link

Make serviceName check null-safe #149

Closed z-oo closed 5 years ago

z-oo commented 5 years ago

Span object stores localEndpoint.serviceName empty string as null so .isEmpty() throws NullPointerException.

z-oo commented 5 years ago

This should fix #148

z-oo commented 5 years ago

@devinsba test added. PTAL.