saturnism commented 5 years ago

130

saturnism commented 5 years ago

PTAL at the approach for zipkin server test.

The actual call to start this test will be moved to run iff on mater branch

saturnism commented 5 years ago

... Apparently it's packaged for both Debian and Ubuntu, so maybe apt-get install-ing it would be cleaner?

Good call. Will update.

saturnism commented 5 years ago

... Apparently it's packaged for both Debian and Ubuntu, so maybe apt-get install-ing it would be cleaner?

Good call. Will update.

oops - not in ubuntu xenial :(

saturnism commented 5 years ago

good news - i think i got the script to run the integration test pretty well. bad news - it's failing :D

https://travis-ci.org/openzipkin/zipkin-gcp/builds/585941140#L4988

Exception in thread "armeria-common-blocking-tasks-1-1" java.lang.NoClassDefFoundError: io/grpc/Context
    at io.opencensus.trace.CurrentSpanUtils.getCurrentSpan(CurrentSpanUtils.java:37)
    at io.opencensus.trace.Tracer.spanBuilder(Tracer.java:308)
    at com.google.api.client.http.HttpRequest.execute(HttpRequest.java:847)
    at com.google.auth.oauth2.ServiceAccountCredentials.refreshAccessToken(ServiceAccountCredentials.java:358)
    at com.google.auth.oauth2.OAuth2Credentials.refresh(OAuth2Credentials.java:165)
    at com.google.auth.oauth2.OAuth2Credentials.getRequestMetadata(OAuth2Credentials.java:151)
    at com.google.auth.Credentials.blockingGetToCallback(Credentials.java:113)
    at com.google.auth.Credentials$1.run(Credentials.java:99)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:834)

codefromthecrypt commented 5 years ago

@saturnism I raised a PR #154 to fix the classpath thing

codefromthecrypt commented 5 years ago

ok pass.. now I'm going to un-vendor wait-for-it using a stable copy we control. https://raw.githubusercontent.com/openzipkin-contrib/wait-for-it/master/wait-for-it.sh

codefromthecrypt commented 5 years ago

Cool stuff @saturnism. Just verified master, and I think we can finally cut a release safely :)

Thanks for all the support on this @anuraaga @elefeint @abesto

+curl --silent localhost:9411/info

+jq .

2019-09-26 13:55:44.316  INFO 5527 --- [           main] z.s.ZipkinServer                         : Started ZipkinServer in 5.535 seconds (JVM running for 7.22)

2019-09-26 13:55:44.508  INFO 5527 --- [orker-epoll-2-2] c.l.a.i.JavaVersionSpecific              : Using version specific APIs from Java9VersionSpecific

{

  "zipkin": {

    "version": "2.17.1-SNAPSHOT",

    "commit": "844c43b"

  }

}

++curl --silent localhost:9411/health

++jq -r .status

+health_check_result=UP

+'[' UP '!=' UP ']'

+echo 'Health check status is up!'

Health check status is up!

openzipkin / zipkin-gcp

Test with Zipkin Server #150

130