search

openzipkin / zipkin-gcp

Reporters and collectors for use in Google Cloud Platform
https://cloud.google.com/trace/docs/zipkin
Apache License 2.0
91 stars 54 forks source link

Moves to Zipkin 2.18 module integration #157

Closed codefromthecrypt closed 4 years ago

codefromthecrypt commented 4 years ago

Zipkin 2.18 no longer uses spring.factories to discover modules. We now use yaml instead of AutoConfiguration. This results in smaller distribution and startup times.

codefromthecrypt commented 4 years ago

the test docker image is failing from grpc context again.. We literally added this to our pom

Caused by: java.lang.ClassNotFoundException: io.grpc.Context
    at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:471)
    at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:588)
    at org.springframework.boot.loader.LaunchedURLClassLoader.loadClass(LaunchedURLClassLoader.java:93)
    at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
    ... 11 more
codefromthecrypt commented 4 years ago

docker test image problem was there before.. fixing.

codefromthecrypt commented 4 years ago

docker is fixed now.

codefromthecrypt commented 4 years ago

will merge on green, then afterwards check master build of travis, too, to keep me honest. I was able to run the test image like this..

docker build -t openzipkin/zipkin-gcp:test -f docker/Dockerfile .

then

docker run -d -p 9411:9411 -e JAVA_OPTS=--logging.level.zipkin2=DEBUG  -e STORAGE_TYPE=stackdriver   -e GOOGLE_APPLICATION_CREDENTIALS=/zipkin/.gcp/credentials.json   -e STACKDRIVER_PROJECT_ID=zipkin-demo    -e JAVA_OPTS=-Dlogging.level.zipkin2=DEBUG -v $HOME/.gcp:/zipkin/.gcp:ro   openzipkin/zipkin-gcp:test