search

openzipkin / zipkin-gcp

Reporters and collectors for use in Google Cloud Platform
https://cloud.google.com/trace/docs/zipkin
Apache License 2.0
91 stars 55 forks source link

Dead links in documentation #198

Closed zmknox closed 10 months ago

zmknox commented 2 years ago

Describe the Bug

Some links out to examples on how to utilize this project seem to go to files that no longer exist in this project.

Such as here: https://github.com/openzipkin/zipkin-gcp#example-integrating-stackdriver-storage where the example links to https://github.com/openzipkin/zipkin-gcp/blob/master/autoconfigure/storage-stackdriver#quick-start , which doesn't exist.

And here: https://github.com/openzipkin/zipkin-gcp/tree/master/docker#stackdriver which links to https://github.com/openzipkin/zipkin-gcp/blob/master/module/storage-stackdriver#configuration , which doesn't exist.

yuriatgoogle commented 2 years ago

+1, I was looking for instructions on how to configure Zipkin to send traces to Cloud Trace and hit the same issues.

jcchavezs commented 2 years ago

Would you open a PR with such fixes?

On Fri, Mar 4, 2022, 17:48 Yuri Grinshteyn @.***> wrote:

+1, I was looking for instructions on how to configure Zipkin to send traces to Cloud Trace and hit the same issues.

— Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin-gcp/issues/198#issuecomment-1059331577, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYARX6E6U3MNIDSZIFV3U6I5E7ANCNFSM5OE2V66A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

codefromthecrypt commented 10 months ago

the easiest way is docker as it is pre-assembled https://github.com/openzipkin/zipkin-gcp/tree/master/docker#running next is to assemble your own https://github.com/openzipkin/zipkin-gcp/tree/master/docker#running

I'll fix the README in a sec

codefromthecrypt commented 10 months ago

@zmknox @yuriatgoogle sorry no one took any action on this. https://github.com/openzipkin/zipkin-gcp/pull/212 should both fix the links and make the build break if it happens again.