openzipkin / zipkin-gcp

Reporters and collectors for use in Google Cloud Platform
https://cloud.google.com/trace/docs/zipkin
Apache License 2.0
91 stars 55 forks source link

Translate Spring 6 HTTP spans to Stackdriver convention #229

Open shakuzen opened 1 week ago

shakuzen commented 1 week ago

From Spring Cloud Sleuth to Spring Framework 6, the tags on HTTP spans produced changed. This updates the SpanTranslator to handle the Spring 6 tags.

Resolves #228

shakuzen commented 1 day ago

I only applied these changes to the SpanTranslator in encoder-stackdriver-brave, but perhaps they should also be applied to the other encoder too.

shakuzen commented 1 day ago

I've added the same logic to the zipkin span translator. @reta would you have any spare time to review?