search

openzipkin / zipkin-go

Zipkin distributed tracing library for go.
Apache License 2.0
612 stars 114 forks source link

chore(deps): bump sarama to v1.40.0 #214

Closed dnwe closed 1 year ago

dnwe commented 1 year ago

Note: the module path has changed to github.com/IBM/sarama since ownership transitioned away from Shopify

dnwe commented 1 year ago

@basvanbeek I added a commit to fix the golangci-lint failures. They weren't introduced by my change, but were caused because the GHA doesn't have a pinned version of golangci-lint

codecov-commenter commented 1 year ago

Codecov Report

Merging #214 (362ac86) into master (a58f3b6) will not change coverage. Report is 1 commits behind head on master. The diff coverage is 50.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   66.83%   66.83%           
=======================================
  Files          36       36           
  Lines        1770     1770           
=======================================
  Hits         1183     1183           
  Misses        542      542           
  Partials       45       45
Files Changed Coverage Δ
reporter/kafka/kafka.go 68.75% <ø> (ø)
middleware/http/client.go 68.51% <50.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

basvanbeek commented 1 year ago

Thanks @dnwe. I'll take a stab at updating some of the code to please the linters and get rid of some deprecation notices.