search

openzipkin / zipkin-js

Zipkin instrumentation for Node.js and browsers
Apache License 2.0
565 stars 171 forks source link

Optimize trace transport #139

Open connectwithnara opened 7 years ago

connectwithnara commented 7 years ago

The batch-recorder (https://github.com/openzipkin/zipkin-js/blob/master/packages/zipkin/src/batch-recorder.js) now collects traces and publishes to the backend one trace at a time. To support a higher sampling %, the traces need to be batched and periodically pushed to the configured backend. A batch should also be compressed to save network and storage for Kafka.

Alternatively, an agent/proxy can be built to deal with these behavior and the traces can be UDP'd local. This agent can then be reused for other language client libraries as well.

This way, the tracing library can be very lean and not have additional library dependency to deal with queueing, compression and transport.

codefromthecrypt commented 7 years ago

the name is a bit misleading.. there's no batching although it does keep references to many spans. The http logger (reporter) actually bundles messages, if you look at it.

jcchavezs commented 5 years ago

Could you please reellaborate on this @narayaruna ?