search

openzipkin / zipkin-php

Zipkin instrumentation for PHP
Apache License 2.0
274 stars 59 forks source link

Add framework instrumentation #40

Open jcchavezs opened 6 years ago

jcchavezs commented 6 years ago

We need to provide framework integrations for zipkin. Priority frameworks are:

  1. [x] Symfony
  2. [ ] Laravel
  3. [ ] Silex
  4. [x] Guzzle http client

Ping @felixfbecker @beberlei

felixfbecker commented 6 years ago

Imo they should definitely be in a separate repo each. They should be able to get their own independent versioning. Noone uses all these frameworks at the same time, so they also shouldn't have to pull in code for it.

jcchavezs commented 6 years ago

Integration with Symfony: https://github.com/jcchavezs/zipkin-instrumentation-symfony

jcchavezs commented 5 years ago

For laravel, there are this libraries so far:

andrei-dascalu commented 3 years ago

Is this something to still look into? Laravel seems supported and Silex is quite dead.

There are some modern frameworks around (Symlex, Lumen, Spiral)

Lumen seems to have https://github.com/shlj/php-zipkin-lumen

jcchavezs commented 3 years ago

There is a PR for laravel. It would be really cool if we could add a test to make sure laravel works fine. Would you be up to do that?