search

openzipkin / zipkin-reporter-java

Shared library for reporting zipkin spans on transports such as http or kafka
Apache License 2.0
126 stars 70 forks source link

updates integration tests and benchmarks to use log4j #224

Closed codefromthecrypt closed 11 months ago

codefromthecrypt commented 11 months ago

Similar to Brave, we don't want a large amount of clutter. To reduce a lot of it, I moved anything that uses MockWebServer to an IT (because it spams logs). I didn't move normal tests to log4j because we have a log capturing test that would fail. If someone wants to take a pass later at that, they could.

codefromthecrypt commented 11 months ago

after this is in, I'll add invoker tests for the rabbitmq amqp-client which proves we can use recent versions and avoid CVE distraction while still maintaining compat (similar to okhttp). Finally, I'll do the same for spring and we're ready to roll ideally with no CVE scares.

codefromthecrypt commented 11 months ago

Thanks for helping me consume so much Azure VM time @anuraaga!