codefromthecrypt
commented
10 months ago cherry-picked a few classes and they look ok now
$ ./mvnw clean install -Prelease -Dgpg.skip -Dmaven.javadoc.skip=true -DskipTests
--snip--
$ file core/target/classes//zipkin2/reporter/AsyncReporter.class
core/target/classes//zipkin2/reporter/AsyncReporter.class: compiled Java class data, version 50.0 (Java 1.6)
$ file brave/target/classes/zipkin2/reporter/brave/AsyncZipkinSpanHandler.class
brave/target/classes/zipkin2/reporter/brave/AsyncZipkinSpanHandler.class: compiled Java class data, version 50.0 (Java 1.6)
$ file okhttp3/target/classes/zipkin2/reporter/okhttp3/OkHttpSender.class
okhttp3/target/classes/zipkin2/reporter/okhttp3/OkHttpSender.class: compiled Java class data, version 51.0 (Java 1.7)
$ file spring-beans/target/classes/zipkin2/reporter/beans/URLConnectionSenderFactoryBean.class
spring-beans/target/classes/zipkin2/reporter/beans/URLConnectionSenderFactoryBean.class: compiled Java class data, version 50.0 (Java 1.6)
This fixes a problem where we weren't releasing jars with the right bytecode level, due to a constant release=8. As we no longer can rely on RetroLambda to rewrite code, I've had to port things to the appropriate bytecode level manually. I also updated build deps that could be.
Fixes #235 and after this will cut a patch release (without any other pending PR)