search

openzipkin / zipkin-reporter-java

Shared library for reporting zipkin spans on transports such as http or kafka
Apache License 2.0
126 stars 70 forks source link

Adds HttpSender to aid proper handling of HttpEndpointSupplier #253

Closed codefromthecrypt closed 9 months ago

codefromthecrypt commented 9 months ago

I noticed that implementing constant and dynamic endpoint handing properly is a chore, especially to test it. This adds HttpSender as a second base type. It handles the edge cases so implementors don't have to.

I also added SenderAdapter which helps deal with the Call contract stuff until we can delete it. I also deleted some async tests from okhttp as we don't promise that sort of behavior on a deprecated and unused function. (For example, otel no longer use the async call stuff).

codefromthecrypt commented 9 months ago

have one more change on top of this that I thought of overnight, but unrelated, so will make another PR