search

openzipkin / zipkin-reporter-java

Shared library for reporting zipkin spans on transports such as http or kafka
Apache License 2.0
126 stars 70 forks source link

io.zipkin.reporter2:zipkin-reporter-java:2.16.3 Test failure #258

Closed shivsrivastava closed 7 months ago

shivsrivastava commented 7 months ago

Describe the Bug

I want to make UAT run successfully for io.zipkin.reporter2:zipkin-reporter-java:2.16.3. But test cases are getting failure due to git access. We are using mvn test.

I have tried with JDK 8,11, and 17 but UAT is failed.

Please Help me on this.

meetankit24 commented 7 months ago

I havealso tried with JDK 8,11, and 17 but UAT is failed.

sourabhmagdum45 commented 7 months ago

I tried with different JDK Version but still UAT status failed

codefromthecrypt commented 7 months ago

I'm not sure what you mean by UAT fail, but you can look how we do tests here:

https://github.com/openzipkin/zipkin-reporter-java/blob/master/build-bin/test

# We use install, not verify, because maven-invoker-tests need modules in this
# project  installed into the local repository before tests run.
./mvnw -T1C install -nsu "$@"

Note if you don't have docker installed, the docker based integration tests will fail

shivsrivastava commented 7 months ago

Will check and confirm.

shivsrivastava commented 7 months ago

I'm not sure what you mean by UAT fail, but you can look how we do tests here:

https://github.com/openzipkin/zipkin-reporter-java/blob/master/build-bin/test

# We use install, not verify, because maven-invoker-tests need modules in this
# project  installed into the local repository before tests run.
./mvnw -T1C install -nsu "$@"

Note if you don't have docker installed, the docker based integration tests will fail

Tried with it but not able to pass UT test cases.

reta commented 7 months ago

@shivsrivastava @meetankit24 could you please share which tests are failing and what operating system you are on?

shivsrivastava commented 7 months ago

@shivsrivastava @meetankit24 could you please share which tests are failing and what operating system you are on?

will provide information.

codefromthecrypt commented 7 months ago

sorry I am closing this issue, as we run tests on every merge. feel free to discuss on gitter what you are running into https://app.gitter.im/#/room/#openzipkin_zipkin:gitter.im

shivsrivastava commented 7 months ago

Here is my log attached . jdk-8 Maven- 3.9.4 build-zipkin-reporter-2.16.3-2024-02-27-12-52-06-337-6267221950.txt

reta commented 7 months ago

build-zipkin-reporter-2.16.3-2024-02-27-12-52-06-337-6267221950.txt

@shivsrivastava I don't see any test failures but license-maven-plugin:4.0.rc2:check complains only:

[27 12:55:48.915] | [INFO] --- license-maven-plugin:4.0.rc2:check (default) @ zipkin-reporter-parent ---
[27 12:55:49.192] | [INFO] Checking licenses...
[27 12:55:49.808] | [WARNING] failure occurred while calling class com.mycila.maven.plugin.license.git.CopyrightRangeProvider
[27 12:55:49.809] | java.lang.RuntimeException: Could not compute the year[WARNING] failure occurred while calling class com.mycila.maven.plugin.license.git.CopyrightRangeProvider
[27 12:55:49.810] | jav[WARNING] failure occurred while calling class 
com.mycila.maven.plugin.license.git.CopyrightRangeProvider
[27 12:55:49.810] | java.lang.RuntimeException: Could not compute the year of the last git commit for file /tmp/pkgs_raw/zipkin-reporter/2.16.3/build-bin/maven/maven_go_offline
[27 12:55:49.810] | of the last git c    a[oWARNING] failure occurred while calling class com.mycila.maven.plugin.license.git.CopyrightRangeProvider
[27 12:55:49.814] | [WARNING] failure occurred while calling class com.mycila.maven.plugin.license.git.CopyrightRangeProvider
[27 12:55:49.814] | java.lang.RuntimeException: Could not compute the year of the last git commit for file /tmp/pkgs_raw/zipkin-reporter/2.16.3/build-bin/docker/configure_docker
[27 12:55:49.814] | at com.mycila.maven.plugin.license.git.CopyrightRangeProvider.getAdditionalProperties (CopyrightRangeProvider.java:94[WARNING] failure occurred while calling class com.mycila.maven.plugin.license.git.CopyrightRangeProvider
[27 12:55:49.814] | java.lang.RuntimeException: Could not compute the year of the last git commit for file /tmp/pkgs_raw/zipkin-reporter/2.16.[WARNING] failure occurred while calling class com.mycila.maven.plugin.license.git.CopyrightRangeProvider
[27 12:55:49.814] | java.lang.RuntimeException: Could not compute the year of the last git commit for file /tmp/pkgs_raw/zipkin-reporter/2.16.3/build-bin/maven/maven_opts
[27 12:55:49.814] | at com.mycila.maven.plugin.license.git.CopyrightRangeProvider.getAdditionalProperties (CopyrightRangeProvider.java:94)
[27 12:55:49.814] | at com.mycila.maven.plugin.license.AbstractLicenseMojo$1.load (AbstractLicenseMojo.java:473)
[27 12:55:49.814] | at com.mycila.maven.plugin.license.document.Document.mergeProperties (Document.java:97)
[27 12:55:49.814] | at com.mycila.maven.plugin.license.header.Header.isMatchForText (Header.java:180)
[27 12:55:49.814] | at com.mycila.maven.plugin.license.document.Document.hasHeader (Document.java:85)
[27 12:55:49.815] | 3/build-bin/git/version_from_trigger_tag
codefromthecrypt commented 7 months ago

also that complaint shouldn't(?) happen anymore as we no longer use date in the license header expression!