search

openzipkin / zipkin-reporter-java

Shared library for reporting zipkin spans on transports such as http or kafka
Apache License 2.0
126 stars 70 forks source link

Avoid encoding list of spans twice in BaseHttpSender #270

Closed shakuzen closed 2 months ago

shakuzen commented 2 months ago

newBody was called twice which would result in encoding the list of spans twice unnecessarily. This change will reduce allocations and copying memory.

codefromthecrypt commented 2 months ago

@reta wanna do one of your version bumps prior to cutting a patch release?

reta commented 2 months ago

@reta wanna do one of your version bumps prior to cutting a patch release?

Sure! Here we are: https://github.com/openzipkin/zipkin-reporter-java/pull/271