openzipkin / zipkin-ruby

zipkin-tracer ruby gem
Apache License 2.0
99 stars 40 forks source link

Is trace logging supported? (like add to MDC) #151

Closed xihw closed 5 years ago

xihw commented 5 years ago

Besides traces are sampled and sent to collector, we wanna traces to be added to mdc, so that whenever there is a log line for a request the corresponding traceId would be present. I know that zipkin java supports it from here https://github.com/apache/incubator-zipkin-brave/tree/master/context/slf4j. ---- Does ruby support it ?

Also based on the README description(https://github.com/openzipkin/zipkin-ruby): :log_tracing - Set to true to log all traces. Only used if traces are not sent to the API or Kafka. --- What is :log_tracing for? Can we utilize it for logging ?