codefromthecrypt
commented
5 years ago sounds fine
On Tue, Oct 8, 2019, 4:23 PM Yohei Kitamura notifications@github.com wrote:
@ykitamura-mdsol commented on this pull request.
In spec/lib/zipkin_b3_single_header_format_spec.rb https://github.com/openzipkin/zipkin-ruby/pull/165#discussion_r332740262 :
@@ -0,0 +1,113 @@ +require 'spec_helper' + +describe ZipkinTracer::B3SingleHeaderFormat do
- let(:b3_single_header_format) { described_class.parse_from_header(b3_single_header) }
- context 'child span' do
@adriancole https://github.com/adriancole In ruby client, we are doing malformed check in another class:
I think we don't need to have malformed tests here but what do you think?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin-ruby/pull/165?email_source=notifications&email_token=AAAPVV4T5L4BLAIP4TIYMILQNT26PA5CNFSM4I6MDYJKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHJUNJA#discussion_r332740262, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAPVV64NCKWTHFYKRJ2HGDQNT26PANCNFSM4I6MDYJA .
This PR is just to support the "reading" part of B3 single header (#126). The writing part is not included.
@adriancole sorry for taking a long time but I like the single header!
@jcarres-mdsol @jfeltesse-mdsol