openzipkin / zipkin-ruby

zipkin-tracer ruby gem
Apache License 2.0
100 stars 38 forks source link

Fix to not flush local component span when a server span or a consumer span is in the stack #179

Closed ykitamura-mdsol closed 4 years ago

ykitamura-mdsol commented 4 years ago

follow up on #178

No span kind is specified for local component spans: https://github.com/openzipkin/zipkin-ruby/blob/50640d9c852c77c33670cedf61031b04b46ea984/lib/zipkin-tracer/trace_client.rb#L20-L23

Updated to not flush local component span (span.kind = nil) when SERVER or CONSUMER span is in the stack.

@adriancole @jcarres-mdsol