search

openzipkin / zipkin-ruby

zipkin-tracer ruby gem
Apache License 2.0
100 stars 38 forks source link

IPv6 support #70

Open codefromthecrypt opened 8 years ago

codefromthecrypt commented 8 years ago

We currently support logging of only IPv4 addresses. Starting with Zipkin 1.4 endpoints can omit IPv4 (by setting Endpoint.ipv4 to 0), and optionally log Endpoint.ipv6 as the raw 16byte address. https://github.com/openzipkin/zipkin-api/blob/master/thrift/zipkinCore.thrift#L276

In json, both are the string formatting http://zipkin.io/zipkin-api

ipv4:
string The text representation of a IPv4 address associated with this endpoint. Ex. 192.168.99.100 ipv6:
string The text representation of a IPv6 address associated with this endpoint. Ex. 2001:db8::c001

jcarres-mdsol commented 7 years ago

My server will provide both ipv4 and ipv6 how do other traces do this? they provide a configuration option on which one to use?

codefromthecrypt commented 7 years ago

it won't be an error to set both