Open codefromthecrypt opened 8 years ago
copying some people of interest, though it affects all
@eirslett @virtuald @yurishkuro @dsyer @marcingrzejszczak
Oh this would fix us needing to do the "fake span" on the server side in Sleuth (in case the communication would end in backend
), wouldn't it?
Oh this would fix us needing to do the "fake span" on the server side in Sleuth, wouldn't it?
yeah, that's what I was thinking
I think this is certainly an improvement. I would be careful with two things, though:
in haystack, they stack both the client and server service names
When looking at the UI, the "owning" service of a span is displayed on the left hand side. For example, an RPC span caused by an instrumented client results in the client's service name.
This surprises some folks, and doesn't look congruent with the top section where both service are mentioned. In some cases, this has led people to make local spans to clarify the server-side visually.
It seems we can make a small adjustment to fix this. By visually indicating a client+server span with both sides, the whole screen seems to make more sense. For example, the top counts the service names and the bottom aligns with that count.