openzipkin / zipkin

Zipkin is a distributed tracing system
https://zipkin.io/
Apache License 2.0
16.95k stars 3.09k forks source link

Display latency between CS/SR/SS/CR annotation timings #1771

Open conorgriffin opened 6 years ago

conorgriffin commented 6 years ago

The zipkin UI currently shows when the above core annotations occurred and the time they occurred relative to the start of the trace, however it would be useful to actually have the calculated latency between each of the events available if desired. This could be done by having a toggle to show additional rows between the existing rows which outlined the latency between each of the recorded annotations.

codefromthecrypt commented 6 years ago

can you attach a screen shot of what you want to see (in osx I use Preview annotations to add text)

ex the span detail screen currently shows timestamps, and I think you might mean on the trace graph view...

conorgriffin commented 6 years ago

Sure, so I'm talking about showing the calculated latencies between the annotations in the detail view where the red arrows are in the first screenshot. You could toggle these on/off with a button as shown in the upper-right of the second screenshot where I've done a rough mockup of what I mean.

screen shot 2017-10-24 at 09 43 52 screen shot 2017-10-24 at 10 07 06
conorgriffin commented 6 years ago

I'd be happy to work on it if this or some variation of it is deemed to be useful

basvanbeek commented 6 years ago

Given different platforms and instrumenting libraries I don't think you can say those annotation timings always properly map latency.

I do see the value of seeing deltas between timings so we could make it more generic and add a delta column to the annotations table which go beyond just CS/SR/SS/CR annotations.

shakuzen commented 5 years ago

I have at times wanted this information without having to do the subtraction in my head.