search

openzipkin / zipkin

Zipkin is a distributed tracing system
https://zipkin.io/
Apache License 2.0
17.02k stars 3.09k forks source link

lens: fixes BASE_PATH handling and re-aligns to old resource paths #3722

Closed codefromthecrypt closed 9 months ago

codefromthecrypt commented 9 months ago

The last commit moved things forward, but it broke how we used the BASE_PATH variable. This reverts to the old logic and fixes up the build so it behaved like the last one.

Along the way, I discovered some tests were disabled, and as able to fix them except one that I need @anuraaga or similar's help on.

@SamTV12345 as a matter of some urgency, once this PR is merged, can you follow-up and test i18n? I noticed the language toggle doesn't work, as it just is always english.

codefromthecrypt commented 9 months ago

ps @tacigar @anuraaga the last release included the source map which is a lot bigger. I noticed we aren't including it at the moment, but maybe that's for the better, vs serving a 10MB sourcemap asset. It has a notable output in our (compressed) binary size.

So, for example, slim went down from 41.9MB to 38.3MB due to not including the sourcemap.

codefromthecrypt commented 9 months ago

merging as the build is broke otherwise. Appreciate any hand in follow-up on things noted!

codefromthecrypt commented 9 months ago

https://github.com/openzipkin/zipkin/issues/3723 for follow-up on broken i18n