openzipkin / zipkin

Zipkin is a distributed tracing system
https://zipkin.io/
Apache License 2.0
17.02k stars 3.09k forks source link

Fix potential github action smells #3770

Closed ceddy4395 closed 6 months ago

ceddy4395 commented 6 months ago

Hey! 🙂 I've made the following changes to your workflow:

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

ceddy4395 commented 6 months ago

Thank you for the approval! I'll have a look if I have some time to spare! :)

I noticed the lint job is failing because of some markdown links giving a 404? Would you like to have that fixed in this PR or in a different one?

codefromthecrypt commented 6 months ago

maybe you can rebase this and possibly it will sort out those links? I think a recent change fixed it.

ceddy4395 commented 6 months ago

@codefromthecrypt Ah yes that did indeed fix the problems! Thank you

codefromthecrypt commented 6 months ago

thanks for the help and teaching us new tricks @ceddy4395!