search

openzipkin / zipkin4net

A .NET client library for Zipkin
Apache License 2.0
342 stars 87 forks source link

Support api v2 #121

Open fedj opened 7 years ago

fedj commented 7 years ago

The new v2 JSON format is easier to understand and the library should support it.

Link to the api

codefromthecrypt commented 6 years ago

this will also make certain practice more straightforward, such as messaging, as it eliminates the possibility of accidentally using the wrong annotations

fedj commented 6 years ago

IMO, there are two stories inside this one:

codefromthecrypt commented 6 years ago

Well yes. Sending to the v2 endpoint requires v2 encoding (json at the moment), but the v2 api style can convert to old encoding with some effort

On 2 Jan 2018 3:45 pm, "Jeanneret Pierre-Hugues" notifications@github.com wrote:

IMO, there are two stories inside this one:

  • Introduce a v2 front API. By front, I mean API for users of this library (having methods like Start and Finish on a Span).
  • Send JSON in v2 format

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin4net/issues/121#issuecomment-354715265, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD611yegMAD-Tw5VJe0qJPNNkRiSgS4ks5tGd57gaJpZM4O6VmD .