search

openziti / desktop-edge-win

Provides a Ziti client for Windows
Apache License 2.0
35 stars 13 forks source link

adding snooze service timeout notification option #432

Closed mary-dcouto closed 3 years ago

mary-dcouto commented 3 years ago

close #430

mary-dcouto commented 3 years ago

i feel like snooze should be more thought out - possibly more broad than this implementation. i'd consider just not merging this at this time but the code seems fine

We may need an option to turn on/off the notifications for now. I named it snooze, but this PR is only to turn on/off notifications. Jeremy, please handle the snooze operation / Notifications in UI when you get some time.

mary-dcouto commented 3 years ago

i feel like snooze should be more thought out - possibly more broad than this implementation. i'd consider just not merging this at this time but the code seems fine

On second thought, I would remove this whole logic of snooze notification from tunnel and let Jeremy handle it in UI. Thanks for the suggestion.