openziti / desktop-edge-win

Provides a Ziti client for Windows
Apache License 2.0
35 stars 13 forks source link

Don't try to auto update if the data service can't be stopped #614

Open dovholuknf opened 8 months ago

dovholuknf commented 8 months ago

Right now, on automatic update, if this error occurs:

[2023-10-24T08:24:11.398Z] ERROR    ZitiUpdateService.UpdateService    Timout while trying to stop service!    System.InvalidOperationException: Cannot stop ziti service on computer '.'. ---> System.ComponentModel.Win32Exception: The service has not been started
   --- End of inner exception stack trace ---
   at System.ServiceProcess.ServiceController.Stop()
   at ZitiUpdateService.UpdateService.StopZiti()

The application will continuously try to update but never succeed because the data service is hung somehow. The user will need to restart Windows, or terminate the ziti-edge-tunnel service before updating can continue. This should be logged and probably surfaced as an error/message to the user to reboot/take action.