openziti / edge

Application-embedded connectivity and zero-trust components
Apache License 2.0
75 stars 19 forks source link

The system property should be visible from the REST API #614

Closed plorenz closed 3 years ago

plorenz commented 3 years ago

Need to figure out if we want to expose this for all entities or just the ones that use it for now (edge router policy)

Russell-Allen commented 3 years ago

I assume both identity and edge router policy could have the system property.

I don't know if this is accurate, but I am thinking of a "system" entity as: any entity who's life cycle (creation, update, delete) is managed indirectly via another entity, or entirely managed by Ziti internal processes.

If I recall correctly, doesn't Ziti automatically create some terminator entities? Wouldn't they fall under this definition of a "system" entity?

plorenz commented 3 years ago

Released under 0.19.9. Closing

plorenz commented 3 years ago

I assume both identity and edge router policy could have the system property.

I don't know if this is accurate, but I am thinking of a "system" entity as: any entity who's life cycle (creation, update, delete) is managed indirectly via another entity, or entirely managed by Ziti internal processes.

If I recall correctly, doesn't Ziti automatically create some terminator entities? Wouldn't they fall under this definition of a "system" entity?

System entity here has a specific functional meaning, which is 'only the system can create/updated/delete this entity'. That is true for the edge router policies. It's not true for router identities, since those can be updated by administrators (mostly to edit role attributes). It's also not currently true for system created terminators, since we let admins delete those. We may at some point mark those as system as well and not allow them to be deleted by admins. At that point we'd also expose the system flag there.