search

openziti / fabric

Geo-scale overlay network and core network programming model
Apache License 2.0
49 stars 14 forks source link

${ZITI_SOURCE} 2 #16

Closed michaelquigley closed 1 year ago

michaelquigley commented 4 years ago

I agree. It's the way it is b/c if ZITI_SOURCE isn't specified, it evaluates to blank and we end up with a relative path ziti-fabric/etc if there's no slash, or an absolute path /ziti-fabric/etc if there is.

If having the absolute path as a fallback is OK, I can switch it. I considered adding logic to check for empty ZITI_SOURCE but there's nothing special about it. Other people might use different values in their config files, so it seemed a little strange to add something to the code for it.

Thoughts?

Originally posted by @plorenz in https://github.com/netfoundry/ziti-fabric/pull/15

michaelquigley commented 4 years ago

We're probably going to want to revisit this with an overall cleaner approach, at some point. I don't actually run my builds out of ~/Repos/nf (the parent directory for ziti-fabric), so this is kind of broken for my workflow anyway.

plorenz commented 1 year ago

Replacing this with openziti/ziti#1426 , which has a concrete proposal for making nicer relative paths in config files.