Closed kevinlmadison closed 1 year ago
@kevinlmadison I peeked at controller, router charts, and those both have the params for image:tag in their deployments.
image: {{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}
and registry login
{{- with .Values.image.pullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
I think you just need optional SHA and optional volumes.
I hadn't even looked yet, I'm gonna get this done tomorrow though!
Le jeu. 30 mars 2023, 16:31, Ken Bingham @.***> a écrit :
@kevinlmadison https://github.com/kevinlmadison I peeked at controller, router charts, and those both have the params for image:tag in their deployments.
image: {{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}
and registry login
{{- with .Values.image.pullSecrets }} imagePullSecrets: {{- toYaml . | nindent 8 }} {{- end }}
I think you just need optional SHA and optional volumes.
— Reply to this email directly, view it on GitHub https://github.com/openziti/helm-charts/issues/80#issuecomment-1490912541, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESFIKU5ON7WQR65LWSI6CTW6XUSHANCNFSM6AAAAAAWKUUZKI . You are receiving this because you were mentioned.Message ID: @.***>
This is done!
The features I'm requesting are generally useful for anyone that might use this helm chart, but we specifically need them for incorporating a Spire setup into Ziti. We need to be able to set the following values in each ziti-* helm chart.