openziti / tlsuv

TLS and HTTP(s) client library for libuv
https://docs.openziti.io/tlsuv/
MIT License
45 stars 7 forks source link

Windows build broken after use of setsockopt instead of uv_tcp_keepalive & friends #205

Closed plajjan closed 7 months ago

plajjan commented 9 months ago

https://github.com/openziti/tlsuv/commit/5afd2320300be50947a2dd78b0b92c9d86980b0e adds loads of setsockopt calls. Previously, at least for the keepalive stuff we called into tcp_src_keepalive which in turn called uv_tcp_keepalive() which is multi-platform. It compiled on Windows. Now with the direct calls to setsockopt, tlsuv no longer compiles for Windows. Perhaps there's a good reason to do direct setsockopt calls, but it needs to be conditioned on something to maintain platform support.

Would be good to have #204 to avoid such regressions.