openziti / ziti-tunnel-sdk-c

Apache License 2.0
43 stars 16 forks source link

ZET shouldn't try to munge root's files #642

Closed qrkourier closed 1 year ago

qrkourier commented 1 year ago

ZET normally runs as non-root user "ziti" and so this will never succeed under normal circumstances:

May 03 18:41:06 localhost.localdomain ziti-edge-tunnel[2343]: sed: couldn't open temporary file /etc/sedLZZv37: Permission denied
May 03 18:41:06 localhost.localdomain ziti-edge-tunnel[2343]: (2343)[        0.107]   ERROR ziti-edge-tunnel:utils.c:31 run_command_va() cmd{sed -z -i 's/nameserver/nameserver 100.64.0.2\nnameserver/' /etc/resolv.conf} failed: 1024/2/No such file or directory
sabedevops commented 1 year ago

674 adds a helpful message to inform the user it doesn't have permissions to manipulate the file, and to either run the binary as root or manually configure their system. Is that sufficient to close this issue?

qrkourier commented 1 year ago

Sounds like it.