search

openziti / ziti

The parent project for OpenZiti. Here you will find the executables for a fully zero trust, application embedded, programmable network @OpenZiti
https://openziti.io
Apache License 2.0
2.69k stars 153 forks source link

Fix links in tutorial #1034

Closed StefanGajic closed 1 year ago

StefanGajic commented 1 year ago

There are two links that are not working in the first-service tutorial.

1st is the one on line 5 https://github.com/openziti/ziti/blob/15c442544b638e03b9f244aec3ac105155be36f8/ziti/cmd/tutorial/tutorials/first-service.md?plain=1#L5 it should be replaced with this link https://github.com/openziti/ziti/blob/release-next/ziti/cmd/tutorial/tutorials/first-service.md

2nd link is on line 245 https://github.com/openziti/ziti/blob/15c442544b638e03b9f244aec3ac105155be36f8/ziti/cmd/tutorial/tutorials/first-service.md?plain=1#L245 it should be replaced with this link https://docs.openziti.io/docs/learn/core-concepts/security/authorization/policies/overview/

StefanGajic commented 1 year ago

@dovholuknf I wanted to make PR and change that myself but I do not have permission to push. Thank you.

dovholuknf commented 1 year ago

@StefanGajic. That's right, you won't have the rights to push it. What you should do is fork the repository, make your change in your fork, then put a PR up from your repo to this one.

StefanGajic commented 1 year ago

Got it. Thanks for explaining @dovholuknf It's right here https://github.com/openziti/ziti/pull/1035 I will close this issue as we have a PR now.

dovholuknf commented 1 year ago

Hi @StefanGajic, actually I need you to enable signed commits in order to accept it into the repo

StefanGajic commented 1 year ago

Thank you @dovholuknf
I have made new PR with commit that is signed. Link is here https://github.com/openziti/ziti/pull/1036