search

openziti / ziti

The parent project for OpenZiti. Here you will find the executables for a fully zero trust, application embedded, programmable network @OpenZiti
https://openziti.io
Apache License 2.0
2.68k stars 153 forks source link

Modify getLatestZiti to have an optional parameter for OS #638

Closed gberl002 closed 2 years ago

gberl002 commented 2 years ago

When following the README for locally building the dockerfile the steps state to use getLatestZiti however, that function pulls the ziti specific to the user's OS when it should actually pull the Ubuntu version since it will be used in docker Ubuntu containers.

Changes needed: Update getLatestZiti to allow forcing the OS type Update the dockerfile README step to use this optional parameter

dovholuknf commented 2 years ago

doesn't it already detect this on your behalf? we just need to modify the detection to find 'arm v amd'?

gberl002 commented 2 years ago

No, for instance, I'm using a Mac so when I call getLatestZiti it downloads the darwin version. The issue is that when I try to build the dockerfile, it will load the darwin executables which won't work in the ubuntu container when deployed.

gberl002 commented 2 years ago

Fixed in https://github.com/openziti/ziti/pull/639 by updating the README to better explain how to build the docker image for various uses.