opera-adt / COMPASS

COregistered Multi-temPorAl Sar Slc
Apache License 2.0
39 stars 18 forks source link

CSLC quality assurance #101

Closed LiangJYu closed 1 year ago

LiangJYu commented 1 year ago

This PR adds:

  1. computation of min, mean, max of CLSC rasters and corrections
  2. determine number of invalid pixels in geocode raster (Very slow!)

To do:

LiangJYu commented 1 year ago

Initial take on CSLC browse image t064_135523_iw2_VV_2022-10-16

vbrancat commented 1 year ago

WRT to the browse image, have you interacted with @nemo794? We do want to have the browse image in EPSG:4326 and with a gray color scale. We need to iterate whether we want to use linear or dB scale and other nits ...

scottstanie commented 1 year ago

One initial note that I made for myself awhile ago: something in addition to total number of invalids/nans, what would be great is a check: "Is there a buffer of N invalid pixels around the burst?" This tells us if the bounding bbox we used was big enough. If there's any side where good data runs up to the edge, we have a problem since it probably cut off some data.

This is what I was thinking of making when figuring out what the burst database margin should be... we'll probably need to check a bunch of data at some point to make sure the margins are ok.

LiangJYu commented 1 year ago

Plots linear and log in grayscale. Working on stripping all the unnecessary stuff... t064_135523_iw2_linear_VV_2022-10-16 t064_135523_iw2_log_VV_2022-10-16

vbrancat commented 1 year ago

@LiangJYu the CSLC-S1 images look cool. Can we improve the contrast by doing some histogram stretching? I have a function to do that if needed

LiangJYu commented 1 year ago

@LiangJYu the CSLC-S1 images look cool. Can we improve the contrast by doing some histogram stretching? I have a function to do that if needed

@vbrancat please share! Thank you!

LiangJYu commented 1 year ago

@LiangJYu the CSLC-S1 images look cool. Can we improve the contrast by doing some histogram stretching? I have a function to do that if needed

Do something like this? image found linked from SO here

scottstanie commented 1 year ago

@LiangJYu the CSLC-S1 images look cool. Can we improve the contrast by doing some histogram stretching? I have a function to do that if needed

Do something like this? image found linked from SO here

If you want something simpler, I might just try gamma correction + clipping at a percentile threshold. It's only a few lines (e.g. like this function) and can look better than log scaling.

LiangJYu commented 1 year ago

On the subject invalids/nans in image, this is probably best done in the isce3 core module by throwing in an isnan accumulator while loop through all the valid pixels.

vbrancat commented 1 year ago

@LiangJYu ready to be reviewed?

LiangJYu commented 1 year ago

@LiangJYu ready to be reviewed?

In a couple hours. Need to test reorg and add documentation.

LiangJYu commented 1 year ago

Code is untested but barring anything seriously wrong this is pretty close to final implementation.

TODO done by tomorrow noon:

vbrancat commented 1 year ago

@seongsujeong do you have time to go through this? We need it for the Gamma delivery!