opera-adt / COMPASS

COregistered Multi-temPorAl Sar Slc
Apache License 2.0
39 stars 18 forks source link

[Bug]: geocode metadata fails #110

Closed taliboliver closed 1 year ago

taliboliver commented 1 year ago

Checked for duplicates

Yes - I've already checked

Describe the bug

When generating gslcs with geocoded metadata get the following error:

journal: s1_rdr2geo burst successfully ran in 0:04:09 (hr:min:sec)
journal: Starting s1_geocode_metadata burst
Traceback (most recent call last):
  File "/mnt/aurora-r0/cabrera/software/tools/COMPASS/src/compass/s1_cslc.py", line 54, in <module>
    main()
  File "/mnt/aurora-r0/cabrera/software/tools/COMPASS/src/compass/s1_cslc.py", line 49, in main
    run(parser.run_config_path, parser.args.grid_type)
  File "/mnt/aurora-r0/cabrera/software/tools/COMPASS/src/compass/s1_cslc.py", line 43, in run
    s1_geocode_slc.run(cfg)
  File "/mnt/aurora-r0/cabrera/software/tools/COMPASS/src/compass/s1_geocode_slc.py", line 102, in run
    s1_geocode_metadata.run(cfg, burst, fetch_from_scratch=True)
  File "/mnt/aurora-r0/cabrera/software/tools/COMPASS/src/compass/s1_geocode_metadata.py", line 73, in run
    geo.lines_per_block = blocksize
AttributeError: 'isce3.ext.isce3.geocode.GeocodeFloat32' object has no attribute 'lines_per_block'

What did you expect?

I expected geocoded metadata

Reproducible steps

1. A sample config file for one burst can be found from 
2. /mnt/aurora-r0/cabrera/data/compass_test/stack/runconfigs/geo_runconfig_20210725_t013_026557_iw2.yaml
3. ran by doing ./stack/run_files/run_20210725_t013_026557_iw2.sh
...

Environment

- Using COMPASS 0.1.3
- isce3 0.10.0 from conda
...
vbrancat commented 1 year ago

@LiangJYu is this related the the block min/max changes in the geocode module? If yes, they should be solved with the next conda release, correct?

LiangJYu commented 1 year ago

@LiangJYu is this related the the block min/max changes in the geocode module? If yes, they should be solved with the next conda release, correct?

@vbrancat This is related the min/max block size issue. conda isce3 v0.10 replaced lines_per_block with min/max_block_size.

This escapes the unit tests because we've disabled rdr2geo processing.

I will submit a PR to fix.

@taliboliver Nice find!

taliboliver commented 1 year ago

Thanks for the quick follow up @vbrancat and @LiangJYu !