opera-adt / COMPASS

COregistered Multi-temPorAl Sar Slc
Apache License 2.0
39 stars 18 forks source link

Fix s1_geocode_metadata crash #112

Closed LiangJYu closed 1 year ago

LiangJYu commented 1 year ago

This PR fixes #110

scottstanie commented 1 year ago

I think it's unrelated to your PR, this is also erroring:

Traceback (most recent call last):
  File "/u/aurora-r0/staniewi/miniconda3/envs/mapping/bin/s1_cslc.py", line 8, in <module>
    sys.exit(main())
  File "/u/aurora-r0/staniewi/repos/COMPASS/src/compass/s1_cslc.py", line 49, in main
    run(parser.run_config_path, parser.args.grid_type)
  File "/u/aurora-r0/staniewi/repos/COMPASS/src/compass/s1_cslc.py", line 43, in run
    s1_geocode_slc.run(cfg)
  File "/u/aurora-r0/staniewi/repos/COMPASS/src/compass/s1_geocode_slc.py", line 191, in run
    corrections_to_h5group(cslc_group, burst, cfg, rg_lut, az_lut, scratch_path,
  File "/u/aurora-r0/staniewi/repos/COMPASS/src/compass/utils/h5_helpers.py", line 661, in corrections_to_h5group
    extended_coeffs_group = correction_group.require_group('extended_coefficients')
UnboundLocalError: local variable 'correction_group' referenced before assignment
scottstanie commented 1 year ago

And the CI build is failing because it might be taking too long? https://app.circleci.com/pipelines/github/opera-adt/COMPASS/289/workflows/14e1cfca-610a-47ac-8c93-5b6652683b6e/jobs/285

#!/bin/bash -eo pipefail
docker run test_image sh -c "cd ~/OPERA/COMPASS && pytest"

============================= test session starts ==============================
platform linux -- Python 3.11.0, pytest-7.2.2, pluggy-1.0.0
rootdir: /home/compass_user/OPERA/COMPASS
collected 4 items

tests/test_ionex.py ..                                                   [ 50%]
tests/test_s1_geocode_slc.py 
CondaError: KeyboardInterrupt

Too long with no output (exceeded 10m0s): context deadline exceeded
LiangJYu commented 1 year ago

And the CI build is failing because it might be taking too long? https://app.circleci.com/pipelines/github/opera-adt/COMPASS/289/workflows/14e1cfca-610a-47ac-8c93-5b6652683b6e/jobs/285

#!/bin/bash -eo pipefail
docker run test_image sh -c "cd ~/OPERA/COMPASS && pytest"

============================= test session starts ==============================
platform linux -- Python 3.11.0, pytest-7.2.2, pluggy-1.0.0
rootdir: /home/compass_user/OPERA/COMPASS
collected 4 items

tests/test_ionex.py ..                                                   [ 50%]
tests/test_s1_geocode_slc.py 
CondaError: KeyboardInterrupt

Too long with no output (exceeded 10m0s): context deadline exceeded

Yup. I'm testing to see if if's faster with layover shadow turned off.

We can also increase the allowed test runtime.

scottstanie commented 1 year ago

Another possible unit test fix: pytest --capture=tee-sys would print out the stderr /stdout stuff while the test is running. it looks like the problem is nothing's getting printed (since pytest captures all by default while the test is running)