search

opera-adt / COMPASS

COregistered Multi-temPorAl Sar Slc
Apache License 2.0
38 stars 18 forks source link

Enable individual LUTs #128

Open vbrancat opened 1 year ago

vbrancat commented 1 year ago

This PR introduces the capability of computing individual correction LUTs by exposing Boolean flag in the schema for each individual correction.

TO DO:

  1. Modify the stack processor to enable/disable individual corrections
  2. Solve QA computation for weather model troposphere
vbrancat commented 1 year ago

@seongsujeong and @LiangJYu it would be great if you have time to go through this PR

scottstanie commented 1 year ago

The s1_geocode_stack.py will have to be changed to: https://github.com/vbrancat/COMPASS/blob/single_lut/src/compass/s1_geocode_stack.py#L287 this one currently will make invalid YAMLs by having the single bool... not sure if we really want to expose all 6 on/off options to that script though. That seems excessive, especially if we expect most people will want the corrections (assuming they all improve things)

LiangJYu commented 1 year ago

The paths from my changes are a mess. I'll fix them as soon as #148 gets merged into main as I see no point in fixing them now and after another merge with main.

LiangJYu commented 1 year ago

Unable replicate failed unit test locally with a new environment created from docker/specifile.txt

Currently investigating why local docker fails differently than CircleCI.