opera-adt / COMPASS

COregistered Multi-temPorAl Sar Slc
Apache License 2.0
38 stars 18 forks source link

Remove /science/SENTINEL1 from CSLC-S1 and static layers #148

Closed vbrancat closed 1 year ago

vbrancat commented 1 year ago

This PR removes the path "s/science/SENTINEL1" to both the CSLC-S1 and the static layers product. In addition, the PR adds new metadata entries to the identification group.

The PR has been tested by generating the CSLC product and the static layers for one burst only.

vbrancat commented 1 year ago

@LiangJYu I don't understand the CI error :s, everything runs smooth locally and on aurora

LiangJYu commented 1 year ago

@LiangJYu I don't understand the CI error :s, everything runs smooth locally and on aurora

@vbrancat the path here needs to be updated. Locally and on aurora you may be accessing files that still have science/SENTINEL1

LiangJYu commented 1 year ago

This needs fixing

vbrancat commented 1 year ago

@LiangJYu and @seongsujeong, this PR is ready for you to review

vbrancat commented 1 year ago

@LiangJYu and @seongsujeong this PR is ready to be reviewed. In the last commit, I included the following changes:

  1. Remove CSLC group
  2. Move corrections to processing_information
  3. Rename corrections to timing_corrections
  4. Remove basename from noise_information and calibration_information groups
  5. Rename vrt_parameters as burst_location_parameters
  6. Renamed s1_burst_metadata as input_burst_metadata
  7. Add a group called parameters in processing_information containing 2 flags to indicate whether the CSLC-S1 phase has been flatten to the ellipsoid and topographic height

Also, I think we should reconsider to to populate dem_source in the inputs group. Can we just give the path to the global VRT used to generate the product? Also, worth having in the schema dem_description? What did RTC-S1 did about this?

seongsujeong commented 1 year ago

What did RTC-S1 did about this?

In case of RTC, we provide the DEM description into ruconfig (example as below), and populate that into the metadata. I'm not sure how much the file name of the global VRT DEM would be useful for users because file name itself is not enough to provide what DEM it actually is.

      dynamic_ancillary_file_group:
          dem_file: dem_4326.tiff
          dem_description: Digital Elevation Model (DEM) for the NASA OPERA project (v1.0) based on the Copernicus DEM 30-m and Copernicus 90-m referenced to the WGS84 ellipsoid
vbrancat commented 1 year ago

@LiangJYu and @seongsujeong would you please go through this PR?

vbrancat commented 1 year ago

@seongsujeong this PR awaits for your review/comments. Thanks

vbrancat commented 1 year ago

@seongsujeong your comments are addressed. Please, have another look at this PR. Thanks :).