search

opera-adt / COMPASS

COregistered Multi-temPorAl Sar Slc
Apache License 2.0
38 stars 18 forks source link

Need to investigate slight overshoot of phase stats #163

Open seongsujeong opened 1 year ago

seongsujeong commented 1 year ago

Checked for duplicates

Yes - I've already checked

Describe the bug

There was a slight overshoot in the stats of phase during pytest in circleCI. Especially, the minimum value of the phase was slightly smaller than -np.pi. More information to be found at the comment in the PR below:

https://github.com/opera-adt/COMPASS/pull/162#issuecomment-1570935879

What did you expect?

I expected [...]

Reproducible steps

1.
2.
3.
...

Environment

- Version of this software [e.g. vX.Y.Z]
- Operating System: [e.g. MacOSX with Docker Desktop vX.Y]
...
vbrancat commented 1 year ago

@seongsujeong can you please verify if we need to investigate this issue?

seongsujeong commented 1 year ago

Suspecting a truncation error. I’ll start taking a look.