search

opera-adt / COMPASS

COregistered Multi-temPorAl Sar Slc
Apache License 2.0
38 stars 17 forks source link

lut.py: use GTiff instead of ENVI to write scratch files #207

Closed scottstanie closed 10 months ago

scottstanie commented 10 months ago

Fixes #206

Not sure if there are any other reasons not to use GTiff, or if this is expected to fail in other ways, but it seems to pass the unit tests and it made the reproducer run successfully.

seongsujeong commented 10 months ago

We were aware of this GDAL issue that I have briefly mentioned in the ISCE3 dev meeting while ago. That is because the first 2-3 bits of the ENV raster is the same as the "magic byte" of the JPEG, and GDAL attempts to load the ENVI file as JPEG.

We've fixed that issue in #164 and #168 by forcing the GDAL drive to ENVI. I think it would be great to know if the issue in #206 is from the most up-to-date version of COMPASS.

scottstanie commented 10 months ago

I can close this if we want to keep that other fix but pick the right exception to catch. We can just add a gdal.UseExceptions() to helpers, and then it will raise a RuntimeError instead of returning None