search

opera-adt / COMPASS

COregistered Multi-temPorAl Sar Slc
Apache License 2.0
39 stars 18 forks source link

download orbit #29

Closed hfattahi closed 2 years ago

hfattahi commented 2 years ago

Borrowing the fetchorbit script from our isce2 stack processor and slightly modifying so that a directory with all safe files can be given as input to loop over and download the orbits for.

yunjunz commented 2 years ago

@hfattahi thanks a lot for these PR. My major comment is to try to uniform the coding style to pep8 when possible. Also while testing the script, I ran into an issue (solvable, I think by modifying the output path to which the orbits are allocated). Also, I think the script should go into the utils folder as it is a functionality more then a workflow. @LiangJYu and @yunjunz would for sure have an opinion on that.

Since this script could be potentially added to a command-line executable, I like it under src/compass.

For the naming, shall we make it consistent with other scripts, e.g. s1_dload_orbit.py?

yunjunz commented 2 years ago

For the convenience and flexibility on the user side, it will be great if we could support:

  1. the input SLC path as safe file, in addition to the directory of it.
  2. --start and --end date, without input safe file/dir, as what we have in topsStack/dloadOrbit.py.
LiangJYu commented 2 years ago

I think this code is a better fit in s1-reader given the substantial amount of duplicate functionality in s1_orbit.py. @hfattahi if you agree, I will resubmit PR in s1-reader.

hfattahi commented 2 years ago

I think this code is a better fit in s1-reader given the substantial amount of duplicate functionality in s1_orbit.py. @hfattahi if you agree, I will resubmit PR in s1-reader.

That is fine. Also I came across this script as well https://github.com/scottstanie/sentineleof . It may does all we need

vbrancat commented 2 years ago

@hfattahi we have moved the orbit download functionality to a new PR in the s1-reader. If you don't mind, I would be inclined to close this PR and move the conversation to the s1-reader repo. Keep the branch just in case. What do you think?

vbrancat commented 2 years ago

Closing since functionality has been included in the s1-reader