opera-adt / COMPASS

COregistered Multi-temPorAl Sar Slc
Apache License 2.0
39 stars 18 forks source link

Docker #41

Closed seongsujeong closed 2 years ago

seongsujeong commented 2 years ago

This PR is to add Dockerfile_cslc_point_release, a Dockerfile for point release. This Dockerfile is originated from the Dockerfile. The major difference between this and the previous Dockefile is that this one specifies the version of the software (i.e. s1-reader, COMPASS) during the image build.

seongsujeong commented 2 years ago

I am good with the modification, however, the test is failing on Circle CI. Any hint why this is happening?

@vbrancat That was because the circle CI configuration was missing in my fork/branch. I updated this branch to date, and it passed the circle CI build test.

vbrancat commented 2 years ago

@rtburns-jpl can you please have a look as well? It would be nice to have this for the point release this upcoming Wednesday (07/27/2022)

yunjunz commented 2 years ago

I am wondering why we need a separate docker file for point release? Could it be merged into the existing docker file?

seongsujeong commented 2 years ago

Thank you all for the feedback regarding this PR. I made further modification to the codes.

The point of this modification is to give some flexibility to building process of the Docker image (i.e. specify the package version for point release) without hard-coding it into Dockerfile, so that the same Dockerfile can be used for both CircleCI and point release. The highlight of the changes are as below:

I decided to keep modifying on this PR, rather than withdrawing it and submitting a new one. Hope it would work fine on the reviewers' end.

vbrancat commented 2 years ago

@rtburns-jpl would you please have a look at this PR? It seems that is needed for our point release

seongsujeong commented 2 years ago

Had a discussion about the future changes of the Dockerfile will be for COMPASS. I will withdraw this PR and submit a new one.