Closed vbrancat closed 1 year ago
Posting Yunjun's preliminary PR review shared on Slack:
Hi Virginia, I am testing your solid Earth tides branch on COMPASS. After configuring the yaml file, s1_cslc.py
went through without error, which is very nice.
What’s the output of this step? It seems that it’s computed but not written into files. I would suggest the following to help your own development/validation and communication with others:
a. embed a debug_mode code inside compass, to help testing and future diagnose. I have a lot of this in mintpy (https://github.com/insarlab/MintPy/blob/0b0a8eb6c6e4ac1945398e378bc881bbfd099b0e/src/mintpy/plate_motion.py#L113-L130). We could discuss this in the CSLC tag-up, or you may bring this up in the ADT meeting (I won’t attend ADT meetings until after AGU due to a time conflict with a class).
OR b. have a jupyter notebook uploaded to our notebook repo.
I actually prefer option a, as it’s easier.
Attached screenshot is the output range and azimuth lut value. Both are not reasonable yet, because:
pysolid
is meter, which need to be converted into our lut unit, which are pixel or second?en2az()
is not right yet, check here (https://github.com/insarlab/MintPy/blob/main/src/mintpy/utils/utils0.py#L621) please. The LOS azimuth angle and orbit azimuth angle are different, see the definitions here (https://github.com/insarlab/MintPy/blob/main/src/mintpy/utils/utils0.py#L531). Because of this easy confusion (to us and to the future users for sure), I suggest we start to document all the geometry and sign conventions in the github wiki (https://github.com/opera-adt/COMPASS/wiki), starting from this one.
After fixing the two, I think we may be good to go for the PR.Below are two more minor suggestions:
heading.rdr
file is actually the LOS azimuth angle, right? If so, I would suggest to use azimuth_angle.rdr
instead, as HEADING angle is technically different from LOS azimuth angle.
Answering Yunjun's comments:
heading.rdr
into azimuth_angle.rdr
as its definition differs from that of the community. I reject this commentincidence.rdr
in incidence_angle.rdr
Closing because branch is stale and takes too much time to resolve conflicts. Will open a new PR.
This PR introduces the Solid Earth tide (SET) correction in the series of LUTs to give as an input to the geocode SLC core module. SET are computed using
pySolid
which has been introduced as a new dependency in COMPASSTO DO:
rdr2geo
, the result ofscipy.interpolate.RegularGridInterpolator
is zero