search

opera-adt / COMPASS

COregistered Multi-temPorAl Sar Slc
Apache License 2.0
39 stars 18 forks source link

More than polarization raster in a single HDF5 #84

Closed LiangJYu closed 1 year ago

LiangJYu commented 1 year ago

This PR modifies s1_geocode_slc so that bursts with the same burst ID but different polarizations are stored in the same HDF5.

LiangJYu commented 1 year ago
  1. dual-pol works for me with my runconfig and dataset.
  2. Fixed - missed this detail from create_output_paths
  3. Fixed - somehow git merge main missed this
vbrancat commented 1 year ago

@LiangJYu can you share your run configuration file and the generated product or point me to that?

LiangJYu commented 1 year ago

@LiangJYu can you share your run configuration file and the generated product or point me to that?

Runconfig and product are on aurora at /home/lyu/data/more_than_one_pol_CSLC

LiangJYu commented 1 year ago

I was able to test the PR and when split_spectrum is disabled, I do see the multiple polarization processed. However, when I enable split_spectrum with dual-pol or co-pol processing I get a big fat segmentation fault. I would say that the Segmentation fault is not related to this PR but it should be addressed asap. Let's just open an issue to keep track of that. Will approve once the issue is opened.

Issue is up. If you can have the segfault trace handy, can you post it the issue?

vbrancat commented 1 year ago

@scottstanie do you have time to review this? Thanks :)

LiangJYu commented 1 year ago

We should probably remove the _temp.vrt file after using it.

$ ls t078_165496_iw2/20220713/
t078_165496_iw2_20220713.h5  t078_165496_iw2_20220713_VH_temp.vrt

In your runconfig, is product_path the same as scratch_path? The following product_path_group in my yaml:

    product_path_group:
      product_path: /home/lyu/proj/opera/product_geo
      sas_output_file: /home/lyu/proj/opera/product_geo
      scratch_path: /home/lyu/proj/opera/scratch_geo

yields the following outputs:

Feb 08, 13:24:43 lyu@XPS-17-9710 ~/proj/opera 
$ tree product_geo
product_geo
└── t064_135523_iw2
    └── 20221016
        └── t064_135523_iw2_20221016_VV.h5
Feb 08, 13:24:51 lyu@XPS-17-9710 ~/proj/opera 
$ tree scratch_geo/
scratch_geo/
└── t064_135523_iw2
    └── 20221016
        └── t064_135523_iw2_20221016_VV_temp.vrt
scottstanie commented 1 year ago

@LiangJYu oh ok, yes for that one I put them as the same folder 👍